Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CosmWasm #115

Closed
RiccardoM opened this issue Mar 10, 2020 · 3 comments · Fixed by #720
Closed

Integrate CosmWasm #115

RiccardoM opened this issue Mar 10, 2020 · 3 comments · Fixed by #720
Assignees
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist

Comments

@RiccardoM
Copy link
Contributor

In order to allow custom applications to implement their features the best way possible without having to fork the Desmos chain, I think we should start taking a look at CosmWasm.

This Cosmos module, developed by Ethan Frey, allows anyone to write smart contracts that can later run on the chain itself.

This could be particularly useful for example when integrating custom posts reporting logics as described inside #50.

@RiccardoM RiccardoM added the kind/new-feature Propose the addition of a new feature that does not yet exist label Mar 10, 2020
@kwunyeung
Copy link
Contributor

I was in their community call today. The current design of CosmWASM is to have its own state for each smart contract. I think this is very good when we have different dapps running on Desmos. Even for the flagging issue, different dapps can keep their states whether a post should be visible or not. I have also asked the upgradability of the contracts and they are tracking this feature here.

@RiccardoM
Copy link
Contributor Author

different dapps can keep their states

This is great!

@RiccardoM RiccardoM added the status/specification This feature is currently in the specification process label May 19, 2020
@RiccardoM RiccardoM removed the status/specification This feature is currently in the specification process label Oct 8, 2020
@RiccardoM RiccardoM modified the milestone: v0.14.0 Oct 14, 2020
@RiccardoM RiccardoM added this to the v0.15.0 milestone Oct 26, 2020
@RiccardoM RiccardoM removed this from the v0.15.0 milestone Dec 7, 2020
@leobragaz
Copy link
Contributor

This should be doable now, I can follow the wasmd example which is already compatible with stargate.

@leobragaz leobragaz mentioned this issue Jan 22, 2021
7 tasks
@leobragaz leobragaz self-assigned this Jun 7, 2021
@mergify mergify bot closed this as completed in #720 Jan 18, 2022
mergify bot pushed a commit that referenced this issue Jan 18, 2022
## Description

Closes: #115. 

This PR integrate the CosmWasm module into Desmos.
At the current stage, no rules are applied to the smart contracts store/instantiate flow and any kind of contract can
be deployed on the network if we will update the testnet as it is.
I think that for testing purposes this is the best choice, however, I will work on an ADR for permissioned contracts and contracts limitations soon. Since Desmos is a social network related project, contracts deployment should be limited to contracts that are social-related.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist
Projects
None yet
3 participants