Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet Release v5.5.2 did not properly update .NET Framework dependency to 4.6.2 from 4.7 #132

Closed
jj39 opened this issue Jul 14, 2024 · 2 comments
Closed

NuGet Release v5.5.2 did not properly update .NET Framework dependency to 4.6.2 from 4.7 #132

jj39 opened this issue Jul 14, 2024 · 2 comments
Assignees
@desjarlais
Labels
bug Something isn't working

Comments

@jj39
Copy link

jj39 commented Jul 14, 2024

NuGet Release v5.5.2 did not properly update .NET Framework dependency to 4.6.2 from 4.7 as per #128

https://www.nuget.org/packages/Scintilla5.NET#dependencies-body-tab

2024_07_13_19_52_54_NuGet_Gallery_Scintilla5 NET_5 5 2
@jj39 jj39 added the bug Something isn't working label Jul 14, 2024
@ahmetsait
Copy link
Collaborator

@desjarlais looks like 38d227d accidentally reverts changes to target framework. Also 5.6.0 would be a more appropriate semver for a release that adds a new feature.

@desjarlais desjarlais self-assigned this Jul 14, 2024
desjarlais added a commit that referenced this issue Jul 14, 2024
@desjarlais
- fix for #132
4e9dcda
@desjarlais
Copy link
Owner

Good catch @ahmetsait, pushing 5.6.0 today to fix these issues. Thanks again for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desjarlais desjarlais

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahmetsait @desjarlais @jj39