Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for .NET Framework 4.6.2 #128

Closed
jj39 opened this issue Jul 2, 2024 · 4 comments
Closed

Restore support for .NET Framework 4.6.2 #128

jj39 opened this issue Jul 2, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jj39
Copy link

jj39 commented Jul 2, 2024

The earliest version of .NET Framework that is still supported is 4.6.2 (end of life is Jan 12, 2027) and ScintillaNET used to have support for 4.6.2 but it seems that 4.6.2 support was removed in favour of 4.7 to use System.ValueTuple: 3b4e975

Please restore support for 4.6.2 by using the System.ValueTuple NuGet package (instead of the built-in System.ValueTuple in .NET Framework 4.7): https://www.nuget.org/packages/System.ValueTuple

@jj39 jj39 added the enhancement New feature or request label Jul 2, 2024
@ahmetsait
Copy link
Collaborator

@jj39 is there actually a hard requirement for your real world project? Windows 10 Creators Update (Version 1703) includes .NET 4.7 as an OS component.

@desjarlais desjarlais self-assigned this Jul 2, 2024
@jj39
Copy link
Author

jj39 commented Jul 2, 2024

I have a commercial app and use the lowest version of .NET Framework possible to ensure maximum compatibility with all potential users. As you mentioned 4.7 requires a minimum version of Windows 10 and does not support some older versions of Windows 10. While I don’t personally use an older version, many people do and requiring 4.7 would mean that my app would be not be able to be used on the computers of people with older versions of Windows 10.

@desjarlais
Copy link
Owner

@ahmetsait How much are we currently using Tuple's and what is your take on bringing back 462? I don't remember seeing any Tuple's but it's been a while since I've reviewed those changes after moving to 4.7.

@ahmetsait
Copy link
Collaborator

Tuple usage is pretty minimal and can be replaced with System.Tuple if you don't want to introduce another NuGet dependency. @desjarlais I don't know when will I have the time so I would encourage you to tackle this if you do.

desjarlais added a commit that referenced this issue Jul 10, 2024
Fix #128: Roll back to net462 by replacing tuples with anonymous types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants