Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting POP-402 issue #256

Merged
merged 9 commits into from
Jun 29, 2023
Merged

Reporting POP-402 issue #256

merged 9 commits into from
Jun 29, 2023

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Mar 27, 2023 •
edited
Loading

Description

  • Reporting the issue [POP-402] No metrics-server detected
  • Fix unexpected output when popeye cannot list RBAC resources

Linked Issues

Fixes #255
Fixes #254

How has this been tested?

As described in the following issues:

go run main.go -o json | jq . | grep 402
              "message": "[POP-402] No metrics-server detected"

go run main.go --kubeconfig popeye-kubeconfig.yml

image

@matheusfm matheusfm mentioned this pull request Mar 28, 2023
Merged
3 tasks
derailed
derailed approved these changes Jun 29, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusfm Thank you so much Matheus for this PR and corrections!
Great catch!!

@derailed derailed merged commit dce0a46 into derailed:master Jun 29, 2023
@matheusfm matheusfm deleted the feat/POP-402-json branch February 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@matheusfm @derailed