Do not close a PR when it supersedes other groups

[judocode]

What are you trying to accomplish?

Prevent this issue, which, in summary:

• When a dependency is in 1 PR, but according to dependabot, it could be in multiple PRs (not in practice because 1 group specifies major and 1 is minor), it incorrectly closes the PR and that dependency won't return to any PR without manual intervention

Anything you want to highlight for special attention from reviewers?

I added an optional param to mark_group_handled called excluding_dependencies, which should work as advertised, and will avoid the exclusion if the dependency is in an existing PR. Also, this should maintain current behavior of closing a PR when a dep exists in more than 1 PR.

I only used this optional param in RefreshGroupUpdatePullRequest, and there are 2 other uses in GroupUpdateAllVersions. We may consider adding excluding_dependencies there as well, but I am not familiar with that path.

How will you know you've accomplished your goal?

I have added a new test along with fixtures that demonstrates this new functionality works. Also, previous functionality and tests are maintained, which include an existing test that will close a PR if it sees a dependency exists in 2 PRs.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[kbukum1]

This method can be simplified to avoid redundant variables (set and names) and directly update the handled dependencies. Here's a suggestion:

def add_handled_dependencies(dependency_names)
  assert_current_directory_set!
  @handled_dependencies[@current_directory] ||= Set.new
  names = Array(dependency_names)
  Dependabot.logger.info("Adding dependencies as handled: (#{names.join(', ')}).")
  @handled_dependencies[@current_directory] += names
end

[judocode]

Ok done

[judocode]

I also just found a solution to the original problem that I've committed in addition to the logging

[judocode]

Not sure why 2.0.0 did not exist here, but did elsewhere

[abdulapopoola]

Thank you so much @judocode !