Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
judocode committed Jan 23, 2025
1 parent 6340856 commit 0f2f7ff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion updater/lib/dependabot/dependency_snapshot.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def mark_group_handled(group, excluding_dependencies = Set.new)
dependencies_in_existing_prs = dependencies_in_existing_pr_for_group(group)

# also add dependencies that might be in the group, as a rebase would add them;
# this avoids individual PR creation that immediately is superseded by a group PR supersede.
# this avoids individual PR creation that immediately is superseded by a group PR supersede
current_dependencies = group.dependencies.map(&:name).reject do |dep|
excluding_dependencies.include?(dep)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,8 @@ def process_group_dependencies(job_group)
# Preprocess to discover existing group PRs and add their dependencies to the handled list before processing
# the refresh. This prevents multiple PRs from being created for the same dependency during the refresh.
dependency_snapshot.groups.each do |group|
# We want to gather all the dependencies that are in existing PRs
# so that other groups will not consider them as handled when they
# are not also in the PR of the group being checked, preventing
# and erroneous PR closure.
# Gather all dependencies in existing PRs so other groups will not consider them as handled when they
# are not also in the PR of the group being checked, preventing erroneous PR closures
group_pr_deps = dependency_snapshot.dependencies_in_existing_pr_for_group(group)
existing_pr_dependencies.merge(group_pr_deps)

Expand Down

0 comments on commit 0f2f7ff

Please sign in to comment.