Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(path): re-add URL examples to @std/path/posix examples #6105

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

devmattrick
Copy link
Contributor

@devmattrick devmattrick commented Oct 10, 2024

I'm not sure if this was intentional, but the documentation added regarding URL manipulation with the @std/path/posix module in #5371 was inadvertently removed in #5900 and #5904.

It seems like the methods that accept a URL object are still in unstable and the current docs for @std/url link to the @std/path/posix module, so I think it might be a good idea to re-add these examples.

@devmattrick devmattrick requested a review from kt3k as a code owner October 10, 2024 23:10
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the path label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (a4cd8af) to head (4d71bb0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6105   +/-   ##
=======================================
  Coverage   96.55%   96.56%           
=======================================
  Files         534      534           
  Lines       40589    40589           
  Branches     6093     6093           
=======================================
+ Hits        39190    39194    +4     
+ Misses       1355     1351    -4     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me. Thanks for the suggestion.

@kt3k kt3k merged commit 123c1fe into denoland:main Oct 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants