Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(path/unstable): support URL as 1st arg of basename() #5900

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 4, 2024

related #5537

@github-actions github-actions bot added the path label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (b808ee6) to head (901fdf9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
path/basename.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5900      +/-   ##
==========================================
- Coverage   96.33%   96.32%   -0.01%     
==========================================
  Files         484      484              
  Lines       39116    39114       -2     
  Branches     5734     5737       +3     
==========================================
- Hits        37682    37677       -5     
- Misses       1390     1393       +3     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title feat(path/unstable): support file URL as 1st arg of basename feat(path/unstable): support URL as 1st arg of basename() Sep 4, 2024
@kt3k kt3k merged commit 7e26160 into denoland:main Sep 4, 2024
17 checks passed
@kt3k kt3k deleted the path-support-url-in-basename branch November 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants