-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] io: update Reader interface #527
Conversation
Looking great. I would suggest to make a simple patch that just adds the EOF symbol to deno and nothing else. |
This PR depends on the change of Reader interface. Only adding EOF symbol to deno core is not enough for passing the CI of this branch. I would suggest the following:
|
I've updated to v0.11.0 but the CI is still failing on Windows at
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - landing this despite the broken test so that we can quickly fix std for v0.11.0
Thanks @kt3k !
This PR updates the Reader interface based on the change introduced by denoland/deno#2591