Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] io: update Reader interface #527

Merged
merged 6 commits into from
Jul 7, 2019
Merged

[WIP] io: update Reader interface #527

merged 6 commits into from
Jul 7, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 29, 2019

This PR updates the Reader interface based on the change introduced by denoland/deno#2591

@ry ry requested a review from piscisaureus June 29, 2019 14:26
kt3k added a commit to kt3k/deno that referenced this pull request Jun 29, 2019
io/bufio.ts Outdated Show resolved Hide resolved
io/bufio.ts Outdated Show resolved Hide resolved
@piscisaureus
Copy link
Member

Looking great.
@ry since this needs to land in concert with changes to deno (we can't get either to pass CI independently), how should we go about landing this?

I would suggest to make a simple patch that just adds the EOF symbol to deno and nothing else.
Then release that.
Then land this.
Then remove ReadResult from Deno.

kt3k added a commit to kt3k/deno that referenced this pull request Jun 30, 2019
@kt3k
Copy link
Member Author

kt3k commented Jun 30, 2019

@piscisaureus

I would suggest to make a simple patch that just adds the EOF symbol to deno and nothing else.
Then release that.
Then land this.

This PR depends on the change of Reader interface. Only adding EOF symbol to deno core is not enough for passing the CI of this branch.

I would suggest the following:

  1. land io: change Reader interface deno#2591
  2. release the next version of deno core
  3. update deno in this branch (CI should pass here)
  4. land this branch

@ry
Copy link
Member

ry commented Jul 7, 2019

I've updated to v0.11.0 but the CI is still failing on Windows at emptyDirIfItExist

AssertionError: Expected function to throw.
    at assertThrowsAsync (file:///D:/a/1/s/testing/asserts.ts:221:15)
    at async emptyDirIfItExist (file:///D:/a/1/s/fs/empty_dir_test.ts:57:9)
    at async runTestsSerial (file:///D:/a/1/s/testing/mod.ts:175:13)
    at async runTests (file:///D:/a/1/s/testing/mod.ts:223:9)
    at async run (file:///D:/a/1/s/test.ts:32:5)

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - landing this despite the broken test so that we can quickly fix std for v0.11.0

Thanks @kt3k !

@ry ry merged commit 3ea90d5 into denoland:master Jul 7, 2019
@kt3k kt3k deleted the feature/update-reader branch July 8, 2019 08:55
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants