New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EOF handling in //io and //ws #405

Closed

4 tasks

ry opened this issue May 14, 2019 · 1 comment

Member

ry commented May 14, 2019 •

edited

Loading

There are several methods I've discovered that do not handle EOF

ws.readFrame()
ioutil.readShort()
ioutil.readInt()
ioutil.readLong()

Probably the best way to handle this is to return null on EOF?

The text was updated successfully, but these errors were encountered:

Member

bartlomieju commented Jul 30, 2019

These issues have been fixed in #527

CC @ry

ry closed this as completed

inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue


          fix: add an empty state to the project list (denoland#405)

812fb60

This PR adds empty states to the project list, it guides new users after
a fresh install.

<img width="862" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/1dd11fbf-7347-4c21-8756-f91c4c60ab59">
<img width="862" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/763b7e0d-8d8b-4bdb-8115-8197a677102b">

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment