Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this navigator.userAgent expected? #20079

Closed
loynoir opened this issue Aug 6, 2023 · 1 comment · Fixed by #20129
Closed

Is this navigator.userAgent expected? #20079

loynoir opened this issue Aug 6, 2023 · 1 comment · Fixed by #20129
Labels
bug Something isn't working correctly good first issue Good for newcomers web related to Web APIs

Comments

@loynoir
Copy link

loynoir commented Aug 6, 2023

Within Deno Worker

  self.postMessage([null, typeof navigator])
  self.postMessage([null, typeof navigator.userAgent])
[ null, "object" ]
[ null, "undefined" ]

This breaks the browser-or-node assumption

https://github.com/flexdinesh/browser-or-node/blob/master/src/index.js#L20-L21

What does the spec say about Worker navigator.userAgent?

Is this expected?

Related flexdinesh/browser-or-node#26
@bartlomieju
Copy link
Member

According to https://developer.mozilla.org/en-US/docs/Web/API/WorkerNavigator it should be available, so it's a bug on our side.

@bartlomieju bartlomieju added bug Something isn't working correctly web related to Web APIs good first issue Good for newcomers labels Aug 6, 2023
@await-ovo await-ovo mentioned this issue Aug 11, 2023
Merged
bartlomieju added a commit that referenced this issue Aug 15, 2023
@await-ovo @bartlomieju
fix(runtime): navigator.userAgent in web worker (#20129)
41cad21 
Fixes #20079

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
littledivy pushed a commit to littledivy/deno that referenced this issue Aug 21, 2023
@await-ovo @bartlomieju @littledivy
fix(runtime): navigator.userAgent in web worker (denoland#20129)
f070bc4 
Fixes denoland#20079

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
littledivy pushed a commit that referenced this issue Aug 21, 2023
@await-ovo @bartlomieju @littledivy
fix(runtime): navigator.userAgent in web worker (#20129)
3ba09ea 
Fixes #20079

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly good first issue Good for newcomers web related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime): navigator.userAgent in web worker await-ovo/deno
2 participants
@bartlomieju @loynoir