fix(runtime): navigator.userAgent in web worker (#20129)

Fixes #20079 --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
denoland · Aug 15, 2023 · 41cad21 · 41cad21
1 parent ddbb5fd
commit 41cad21
Show file tree

Hide file tree

Showing 5 changed files with 63 additions and 16 deletions.
diff --git a/cli/tests/testdata/workers/test.ts b/cli/tests/testdata/workers/test.ts
@@ -119,6 +119,26 @@ Deno.test({
   },
 });
 
+Deno.test({
+  name: "worker navigator",
+  fn: async function () {
+    const workerOptions: WorkerOptions = { type: "module" };
+    const w = new Worker(
+      import.meta.resolve("./worker_navigator.ts"),
+      workerOptions,
+    );
+
+    const promise = deferred();
+    w.onmessage = (e) => {
+      promise.resolve(e.data);
+    };
+
+    w.postMessage("Hello, world!");
+    assertEquals(await promise, "string, object, string, number");
+    w.terminate();
+  },
+});
+
 Deno.test({
   name: "worker fetch API",
   fn: async function () {

diff --git a/cli/tests/testdata/workers/worker_navigator.ts b/cli/tests/testdata/workers/worker_navigator.ts
@@ -0,0 +1,11 @@
+onmessage = function () {
+  postMessage(
+    [
+      typeof navigator.language,
+      typeof navigator.languages,
+      typeof navigator.userAgent,
+      typeof navigator.hardwareConcurrency,
+    ].join(", "),
+  );
+  close();
+};
diff --git a/runtime/js/98_global_scope.js b/runtime/js/98_global_scope.js
@@ -225,21 +225,29 @@ ObjectDefineProperties(WorkerNavigator.prototype, {
       webidl.assertBranded(this, WorkerNavigatorPrototype);
       return numCpus;
     },
-    language: {
-      configurable: true,
-      enumerable: true,
-      get() {
-        webidl.assertBranded(this, WorkerNavigatorPrototype);
-        return language;
-      },
+  },
+  userAgent: {
+    configurable: true,
+    enumerable: true,
+    get() {
+      webidl.assertBranded(this, WorkerNavigatorPrototype);
+      return userAgent;
+    },
+  },
+  language: {
+    configurable: true,
+    enumerable: true,
+    get() {
+      webidl.assertBranded(this, WorkerNavigatorPrototype);
+      return language;
     },
-    languages: {
-      configurable: true,
-      enumerable: true,
-      get() {
-        webidl.assertBranded(this, WorkerNavigatorPrototype);
-        return [language];
-      },
+  },
+  languages: {
+    configurable: true,
+    enumerable: true,
+    get() {
+      webidl.assertBranded(this, WorkerNavigatorPrototype);
+      return [language];
     },
   },
 });

diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js
@@ -567,7 +567,7 @@ function bootstrapWorkerRuntime(
     10: pid,
     11: target,
     12: v8Version,
-    // 13: userAgent,
+    13: userAgent,
     // 14: inspectFlag,
     15: enableTestingFeaturesFlag,
   } = runtimeOptions;
@@ -633,6 +633,7 @@ function bootstrapWorkerRuntime(
   location.setLocationHref(location_);
 
   setNumCpus(cpuCount);
+  setUserAgent(userAgent);
   setLanguage(locale);
 
   globalThis.pollForMessages = pollForMessages;

diff --git a/tools/wpt/expectation.json b/tools/wpt/expectation.json
@@ -6177,7 +6177,14 @@
             "taintEnabled",
             "oscpu"
           ],
-          "navigator.any.worker.html": false,
+          "navigator.any.worker.html": [
+            "appCodeName",
+            "appName",
+            "appVersion",
+            "platform",
+            "product",
+            "userAgent value"
+          ],
           "per-global.window.html": false
         }
       }