Upgrade to Methadone 1.9.1 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the dots from the expected task description because newer rake versions strip the last dot from the description for `rake -T`
fix the failing bootstrap feature
…hen_no_logger_set Added a helpful error message when you forget to set a logger.
I think it's related to this: rubinius/rubinius#2827
This works in the base logger, but Methadone was asking the string if it was a tty, which it isn't, but doesn't even respond to, so beefing this up. Closes davetron5000#73
…ck licenses are personalized
added rspec-2.99 with tests so now it works out of the box again
Fix a typo in retrieving the username from git. Add the Apache license to the cucumber scenario.
…ENSE.txt" should not exist Currently, the file still gets created by `bundle gem` and contains the MIT license. Also move the slowest scenarios to the end in features/license.feature to the end of the file.
Update readme
…mspec Remove rake from gemspec template
[ci skip]
Use File.expand_path instead of File.join in defaults_from_config_file to allow absolute paths. Relative paths will still be relative to HOME. Additionally, ~ expansion is now also possible. It seems reasonable to me that nobody will be using leading slashes for their config filenames so far, so it should be safe to assume that when they do, they want absolute paths. However, to be safe you might want to consider this a API change.
…solute-config-files
This fixes an issue with JRuby 1.8
This conditionally adds test-unit as a dep fo Ruby 2.2 and above.
…sue-for-2.2 Fix test unit issue for 2.2
Version 1.9.1 * tag 'v1.9.1': (60 commits) bump version remove unsupported Rubies deal with test/unit missing on 2.2 latest ruby on travis lots of cleanups for 2.2.2 kill me now situps oy vey bump version do not care about that patch level oops, missed one Explicitly get path of Tempfile in test slight update to docs typo lock i18n to a verison that works with older rubies Allow absolute config files (davetron5000#87) try this try a specific version of Ruby bump version Remove rake version from gemspec template ...
|
tests pass but seems that the coverage report is failing. Finished in 1.316846085 seconds.140 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed106.31 tests/s, 57.71 assertions/s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in davetron5000#95
Merged upstream changes from tab v1.9.1 and fixed the build to pass.