Added a helpful error message when you forget to set a logger. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I don't think this is causing the CI failure for rbx, but I'll look into that before releasing. Thanks for doing this and thanks for the test coverage. |
davetron5000
added a commit
that referenced
this pull request
Oct 30, 2013
…r_set Added a helpful error message when you forget to set a logger.
|
You bet...thanks for the great gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was puzzled for a while at an unhelpful NoMethodError. I had forgotten to include
Methadone::CLILoggingnor provided my own logger.This provides a helpful error message. I included a passing test.