add option to copy links instead opening #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
zeitschlag
reviewed
Dec 18, 2024
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
Co-authored-by: zeitschlag <hallo@bullenscheisse.de>
zeitschlag
approved these changes
Dec 18, 2024
|
CHANGLOG was missing, added a commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds detection if a link was long-tapped and offers the option "Copy Link" (instead of "Copy Text").
i was also playing around with offering both options and even with a totally separate menu, however, this seems both not better UX wise and is not worth additional effort. it is easy not to tap the link - and the other way round, if the links was accidentally tapped (eg. cause it is long), it is nice to have all options at hand (reactions :)
this method handles most kind of links: URLs, emails, phonenumber, commands - and adds few overhead, so that it is also easily mantainable in the future
this is how it looks like:
successor of #2155, #1729 and #1808
feature request at https://support.delta.chat/t/copy-a-link-from-a-message-on-long-press-in-ios/2755