Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try-to-add-longpress-handler-and-failed #1808

Closed

Conversation

Simon-Laux
Copy link
Member

No description provided.

@Simon-Laux Simon-Laux force-pushed the simon/try-to-add-longpress-handler-and-failed branch from 1990ed0 to 8bfd270 Compare February 8, 2023 17:30
@cyBerta
Copy link
Contributor

cyBerta commented Feb 9, 2023

alternative approach could be to always ask on a simple tap on a url link to either copy or open the link. That might make sense anyways, so that tapping on a link not automatically leads to opening a link in a browser.

@r10s
Copy link
Member

r10s commented Feb 9, 2023

alternative approach could be to always ask on a simple tap on a url link to either copy or open the link

hm, while understanding the idea, this is nothing what ppl usually expect when tapping a link; esp. as the link is already shown and there is no surprise in what will be opened.

we could maybe add a "Copy Link" item to the existing context menu when the text contains a link (any maybe more items if there are more links) ... but i think, that is also an ugly workaround.

i am positive that we figure out how to deal with long-taps at some point, however, this is noting urgent in any way just now.

@cyBerta
Copy link
Contributor

cyBerta commented Feb 9, 2023

alternative approach could be to always ask on a simple tap on a url link to either copy or open the link. That might make sense anyways, so that tapping on a link not automatically leads to opening a link in a browser.

this is also what telegram does for example (asking to open a link). So UX wise users might also know this behavior from other apps.

@r10s
Copy link
Member

r10s commented Feb 9, 2023

this is also what telegram does for example (asking to open a link). So UX wise users might also know this behavior from other apps.

weird, have never seen that. maybe telegram want ppl to stay in their cage :)

EDIT: just double-checked that on telegram-ios, telegram-desktop(mac) and telegram-android with default config, i have not seen a question/popup/dialog when tapping a link. maybe some config set? but i still think, this is not what is expected when tapping a link and it is not what usually happens, also not on deltachat android or desktop.

@cyBerta
Copy link
Contributor

cyBerta commented Feb 13, 2023

hmmm... the pop-up shows up if I long-tap in TG iOS, my fault.

@Simon-Laux
Copy link
Member Author

I would really appreciate having this feature in my day to day use, @cyBerta do you have an idea on where to listen for the long tap event on links?

@r10s
Copy link
Member

r10s commented Oct 5, 2023

moving stale draft to resurrection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed PRs and Issues
Development

Successfully merging this pull request may close these issues.

3 participants