refactor: MsgId::update_download_state: Don't fail if the message doesn't exist anymore #6032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no test in 22e5bf8, but here a test is desirable because |
…sn't exist anymore If a race happens and the message disappears, there's just nothing to do and no sense to fail. Follow-up to 22e5bf8.
iequidoo
force-pushed
the
iequidoo/MsgId.update_download_state
branch
from
877211b
to
4d9a144
Compare
link2xt
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a race happens and the message disappears, there's just nothing to do and no sense to fail. Follow-up to 22e5bf8.
This is
refactorbecause such a race is unlikely.