fix(download_msg): do not fail if the message does not exist anymore #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix IMAP loop may get stuck trying to download non-existing message over and over like this: ``` src/imap.rs:372: Logging into IMAP server with LOGIN. src/imap.rs:388: Successfully logged into IMAP server src/scheduler.rs:361: Failed to download message Msg#3467: Message Msg#3467 does not exist. src/scheduler.rs:418: Failed fetch_idle: Failed to download messages: Message Msg#3467 does not exist ``` The whole download operation fails due to attempt to set the state of non-existing message to "failed". Now download of the message will "succeed" if the message does not exist and we don't try to set its state.
adbenitez
approved these changes
Oct 3, 2024
iequidoo
reviewed
Oct 4, 2024
| // Probably the message expired due to `delete_device_after` | ||
| // setting or was otherwise removed from the device, | ||
| // so we don't want it to reappear anyway. | ||
| return Ok(()); |
There was a problem hiding this comment.
I think this should be better fixed in scheduler::download_msgs(), otherwise it's easy to break again. Maybe this should return bool telling whether the message has been downloaded, which is handled download_msgs(). Otherwise the fix is unobvious when looking only here or into download_msgs()
There was a problem hiding this comment.
Finally i think this fix is the best option, but there's also update_download_state() that should be changed the same way: #6032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix IMAP loop may get stuck
trying to download non-existing message over and over like this:
The whole download operation fails
due to attempt to set the state of non-existing message to "failed". Now download of the message
will "succeed" if the message does not exist
and we don't try to set its state.