ref(*): pass io.ReadCloser instead of string body #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| defer func() { | ||
| io.Copy(ioutil.Discard, res.Body) | ||
| res.Body.Close() | ||
| }() |
There was a problem hiding this comment.
don't you want to schedule this after the ioutil.ReadAll returns?
There was a problem hiding this comment.
sorry, I misread and assumed the defer was actually a go. ignore me
Joshua-Anderson
force-pushed
the
use-reader
branch
from
7dca4be
to
61cbe35
Compare
| return "", ErrNoLogs | ||
| } | ||
|
|
||
| // We need to trim a few characters off the front and end of the string | ||
| return body[2 : len(body)-1], nil | ||
| return string(body[2 : len(body)-1]), nil |
There was a problem hiding this comment.
can you do a bounds check here?
There was a problem hiding this comment.
I'm now doing a bounds check in the previous if statement.
|
code LGTM after #11 (comment) is addressed |
Joshua-Anderson
force-pushed
the
use-reader
branch
from
61cbe35
to
bcca709
Compare
2 tasks
cscatolini
pushed a commit
to topfreegames/controller-sdk-go
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @arschles
Note that this PR removes the current system of error messages, because it is incompatible with the
io.ReadCloserrefactor.My work over the next few days will be to implement a new error system based on error constants that can be checked by sdk users and that will be compatible with
io.Readers. If we don't want to temporarily remove verbose error messages, I can get this reviewed, then submit a new PR with both this refactor and the error messages refactor.Also note that this does not affect
LimitedRequest(). This is because it needs to parse the json body in order to work, meaning that the response already has to be converted to a string. I'm open for ways that this could be better implemented.I'm returning the entire
*http.Responseobject as opposed to just the body, because some of the information, such as response code, can be used to return specific error messages for an action with my error messages rewrite.