fix(errors): return actionable errors from API #13
Conversation
|
I also intend to add a |
| case 400: | ||
| bodyMap := make(map[string]interface{}) | ||
| if err := json.NewDecoder(res.Body).Decode(&bodyMap); err != nil { | ||
| return ErrParsing |
There was a problem hiding this comment.
perhaps we should also return the response body so the user can determine the error on their own?
| if err != nil { | ||
| return api.App{}, err | ||
| } | ||
| // Fix json.Decoder bug in <go1.7 |
There was a problem hiding this comment.
Maybe this should be // TODO: Remove when json.Decoder bug is fixed (go >= 1.7) ? It's unfortunate that this has to be repeated everywhere Decode is used.
Also do you have a reference for this json.Decoder issue? Just curious.
There was a problem hiding this comment.
It was caught in google's github-api repo: google/go-github#317
I'll make a PR to reformat the warning to what you suggested everywhere.
Joshua-Anderson
changed the title
|
This is no longer WIP. @helgi you had some concerns about my approach, could you please review? |
|
@bacongobbler You accidentally LGTMed this twice ❤️! I removed your second LGTM so somebody else can review it. |
|
whoops :P |
|
I'd rather want to fix the API where possible with more identifable information than to parse things like this but good enough for now. An improvement for sure |
This tries to strike a balance between supporting every possible error, which is infeasible because of how many (undocumented) errors exist, and supporting the most useful errors.
The most useful errors have their own type, and the less common errors return a unknown error.