Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support python 3.13 #8965

Merged
merged 4 commits into from
Mar 5, 2025
Merged

build: support python 3.13 #8965

merged 4 commits into from
Mar 5, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Mar 4, 2025

Related Issues

I experimented with Python 3.13 locally (Ubuntu) and in a draft PR (#8959; Ubuntu, MacOs, Windows).

What I found

Proposed Changes:

  • support Python 3.13 and communicate it

How did you test it?

CI; if you are curious, check also tests in #8959.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13672865207

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 90.218%

Totals Coverage Status
Change from base Build 13652854933: 0.002%
Covered Lines: 9601
Relevant Lines: 10642

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review March 4, 2025 17:24
@anakin87 anakin87 requested review from a team as code owners March 4, 2025 17:24
@anakin87 anakin87 requested review from dfokina and sjrl and removed request for a team March 4, 2025 17:24
@@ -8,7 +8,7 @@ dynamic = ["version"]
description = "LLM framework to build customizable, production-ready LLM applications. Connect components (models, vector DBs, file converters) to pipelines or agents that can interact with your data."
readme = "README.md"
license = "Apache-2.0"
requires-python = ">=3.8,<3.13"
requires-python = ">=3.8"
Copy link
Contributor

@sjrl sjrl Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be best practice to add ,<3.14? Or should we only restrict it once new versions of python come out and we figure out then that the version doesn't work?

Copy link
Member Author

@anakin87 anakin87 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, perhaps it was a mistake to restrict to Python <3.13 (done by me in #8547). I would prefer not to officially support python 3.14 but leave users free to experiment and report errors when this version becomes available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

@github-actions github-actions bot added the topic:DX Developer Experience label Mar 5, 2025
CONTRIBUTING.md Outdated
@@ -147,6 +147,8 @@ next contribution!

### Setting up your development environment

*Currently, to contribute to Haystack, you must use a version of Python >=3.9 and <3.13.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a bit more explanation for why less than 3.13? Or rather say all tests (or the testing dev env) will not run locally if using python 3.13. They could theoretically contribute to Haystack still and just rely on our CI to run tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me

@anakin87 anakin87 enabled auto-merge (squash) March 5, 2025 09:42
@anakin87 anakin87 merged commit 10f11d4 into main Mar 5, 2025
17 checks passed
@anakin87 anakin87 deleted the allow-python-3.13 branch March 5, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove restriction python<3.13 in pyproject.toml
3 participants