Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declare requires-python<3.13 in pyproject #8547

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

anakin87
Copy link
Member

Related Issues

As discovered by @silvanocerza and also reported in #8543, there are some incompatibiliets with python 3.13.

We should explicitly declare this in pyproject, to avoid problems when installing the project with hatch.

Proposed Changes:

  • requires-python = ">=3.8,<3.13"

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review November 15, 2024 09:00
@anakin87 anakin87 requested a review from a team as a code owner November 15, 2024 09:00
@anakin87 anakin87 requested review from shadeMe and removed request for a team November 15, 2024 09:00
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 15, 2024
@anakin87 anakin87 added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Nov 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11853511028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.204%

Totals Coverage Status
Change from base Build 11840168232: 0.0%
Covered Lines: 7836
Relevant Lines: 8687

💛 - Coveralls

@anakin87 anakin87 changed the title chore: declare requires-python<3.13 in pyproject chore: declare requires-python<3.13 in pyproject; unpin dulwich Nov 15, 2024
@anakin87 anakin87 changed the title chore: declare requires-python<3.13 in pyproject; unpin dulwich chore: declare requires-python<3.13 in pyproject Nov 15, 2024
@anakin87
Copy link
Member Author

I also tried to unpin dulwich, but this would make installation on Windows and MacOs a bit slower (+10/15s), so I reverted this change.

@anakin87 anakin87 enabled auto-merge (squash) November 15, 2024 09:26
@anakin87 anakin87 merged commit f085959 into main Nov 15, 2024
16 checks passed
@anakin87 anakin87 deleted the restrict-python-versions branch November 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants