Add support of take on MXNet engine
#1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/src/main/java/ai/djl/ndarray/NDArray.java # engines/mxnet/mxnet-engine/src/main/java/ai/djl/mxnet/engine/MxNDArray.java
KexinFeng
changed the title
take to MXNet enginetake on MXNet engine
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
============================================
- Coverage 72.08% 70.84% -1.25%
- Complexity 5126 5448 +322
============================================
Files 473 508 +35
Lines 21970 23863 +1893
Branches 2351 2597 +246
============================================
+ Hits 15838 16906 +1068
- Misses 4925 5658 +733
- Partials 1207 1299 +92
Continue to review full report at Codecov.
|
zachgk
reviewed
May 13, 2022
| throw new UnsupportedOperationException("Not implemented yet."); | ||
| MxOpParams params = new MxOpParams(); | ||
| params.addParam("shape", "(-1,)"); | ||
| NDList flattened = manager.invoke("reshape", new NDList(this), params); |
There was a problem hiding this comment.
You can just use the external reshape here like NDArray flattened = this.reshape(...) or this.flatten().
lanking520
approved these changes
Jun 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr follows #1627
takefunction in MXNet is defined differently from numpy or pytorch. It is implemented byflattenandtakein MXNet.