Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of take from pytorch #1627

Merged
merged 10 commits into from
May 12, 2022
Merged

Support of take from pytorch #1627

merged 10 commits into from
May 12, 2022

Conversation

KexinFeng
Copy link
Contributor

@KexinFeng KexinFeng commented May 6, 2022

Description

This is a follow-up on PR #1622. The take feature will enable more advanced indexing.

It's the same as take in numpy and pytorch.

Defination of NDArray take(NDArray index):
Returns a partial pointed by the index array, according to row-major-ordering linear indexing.
The shape of the output is decided by that of index.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1627 (706ec85) into master (bb5073f) will decrease coverage by 1.22%.
The diff coverage is 61.96%.

@@             Coverage Diff              @@
##             master    #1627      +/-   ##
============================================
- Coverage     72.08%   70.86%   -1.23%     
- Complexity     5126     5438     +312     
============================================
  Files           473      507      +34     
  Lines         21970    23784    +1814     
  Branches       2351     2589     +238     
============================================
+ Hits          15838    16854    +1016     
- Misses         4925     5636     +711     
- Partials       1207     1294      +87     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...ain/java/ai/djl/ndarray/index/dim/NDIndexPick.java 100.00% <ø> (ø)
api/src/main/java/ai/djl/nn/Blocks.java 75.00% <0.00%> (-25.00%) ⬇️
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d3479...706ec85. Read the comment docs.

@KexinFeng KexinFeng changed the title take_dev Support of take from pytorch May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants