-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of take from pytorch #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
============================================
- Coverage 72.08% 70.86% -1.23%
- Complexity 5126 5438 +312
============================================
Files 473 507 +34
Lines 21970 23784 +1814
Branches 2351 2589 +238
============================================
+ Hits 15838 16854 +1016
- Misses 4925 5636 +711
- Partials 1207 1294 +87
Continue to review full report at Codecov.
|
lanking520
approved these changes
May 12, 2022
zachgk
approved these changes
May 12, 2022
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up on PR #1622. The
take
feature will enable more advanced indexing.It's the same as
take
in numpy and pytorch.Defination of
NDArray take(NDArray index)
:Returns a partial pointed by the index array, according to row-major-ordering linear indexing.
The shape of the output is decided by that of
index
.