[Glenfly] [Deepin Kernel SIG] Fix compile errors with clang-19 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix follow error: error: unknown warning option '-Wno-missing-attributes' [-Werror,-Wunknown-warning-option] Signed-off-by: WangYuli <wangyuli@uniontech.com>
There is a spelling mistake of 'peff' which should be 'perf'.
Fix follow compile error with clang-19:
drivers/gpu/drm/arise/shared/gf_perf.h:15:9: error: '__gf_perf_h__' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
15 | #ifndef __gf_perf_h__
| ^~~~~~~~~~~~~
drivers/gpu/drm/arise/shared/gf_perf.h:16:9: note: '__gf_peff_h__' is defined here; did you mean '__gf_perf_h__'?
16 | #define __gf_peff_h__
| ^~~~~~~~~~~~~
| __gf_perf_h__
1 error generated.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Fix follow compile error with clang-19:
drivers/gpu/drm/arise/cbios/Device/Monitor/EDPPanel/CBiosITN156.c:136:22: error: implicit truncation from 'int' to bit-field changes value from 2 to 0 [-Werror,-Wbitfield-constant-conversion]
136 | /*.Flags = */0x2,//backlight control = 0, use hard code link para
| ^~~
1 error generated.
According to the comments, 'Flags' should be 0.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
As ulTemp is declared as CBIOS_U32, it cannot <126 and >125 at the
same time.
Fix follow error with clang-19:
drivers/gpu/drm/arise/cbios/Util/CBiosUtil.c:55:25: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare]
55 | else if((ulTemp<126)&&(ulTemp>125))
| ~~~~~~~~~~~~^~~~~~~~~~~~~~
1 error generated.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Fix follow error with clang-19:
drivers/gpu/drm/arise/cbios/Device/Monitor/CBiosHDMIMonitor.c:200:44: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
200 | if((pAVIInfoFrameData->ColorFormat == 0))//RGB
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/gpu/drm/arise/cbios/Device/Monitor/CBiosHDMIMonitor.c:200:44: note: remove extraneous parentheses around the comparison to silence this warning
200 | if((pAVIInfoFrameData->ColorFormat == 0))//RGB
| ~ ^ ~
drivers/gpu/drm/arise/cbios/Device/Monitor/CBiosHDMIMonitor.c:200:44: note: use '=' to turn this equality comparison into an assignment
200 | if((pAVIInfoFrameData->ColorFormat == 0))//RGB
| ^~
| =
1 error generated.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Fix follow compile errors with clang-19:
drivers/gpu/drm/arise/linux/os_interface.c:1995:10: error: explicitly assigning value of variable of type 'unsigned long' to itself [-Werror,-Wself-assign]
1995 | base = base;
| ~~~~ ^ ~~~~
drivers/gpu/drm/arise/linux/os_interface.c:1996:10: error: explicitly assigning value of variable of type 'unsigned long' to itself [-Werror,-Wself-assign]
1996 | size = size;
| ~~~~ ^ ~~~~
2 errors generated.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Avenger-285714
merged commit f88ecca
into
deepin-community:linux-6.6.y
3 of 5 checks passed
deepin pr auto review代码审查意见：
以上是代码审查的初步意见，具体的改进还需要根据项目的具体需求和上下文来确定。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Avenger-285714
pushed a commit
to KernelSIG-cn/Linux-LTS-CN-6.6-dev
that referenced
this pull request
Dec 29, 2024
[Glenfly]: This version driver is the initial version for linux kernel 6.6, and added basic arch support for amd64/arm64/loongarch64. Test pass on deepin V23. Version: 25.00.36. Link: deepin-community/kernel#333 Link: https://gitee.com/openkylin/linux/pulls/241 Link: deepin-community/kernel#390 Link: deepin-community/kernel#490 Link: deepin-community/kernel#496 Link: deepin-community/kernel#509 Co-developed-by: WangYuli <wangyuli@uniontech.com> Signed-off-by: WangYuli <wangyuli@uniontech.com> Signed-off-by: brightyi <brightyi@glenfly.com> Signed-off-by: WangYuli <wangyuli@uniontech.com>
Avenger-285714
pushed a commit
to KernelSIG-cn/Linux-LTS-CN-6.6-dev
that referenced
this pull request
Jan 4, 2025
[Glenfly]: This version driver is the initial version for linux kernel 6.6, and added basic arch support for amd64/arm64/loongarch64. Test pass on deepin V23. Version: 25.00.36. Link: deepin-community/kernel#333 Link: https://gitee.com/openkylin/linux/pulls/241 Link: deepin-community/kernel#390 Link: deepin-community/kernel#490 Link: deepin-community/kernel#496 Link: deepin-community/kernel#509 Co-developed-by: WangYuli <wangyuli@uniontech.com> Signed-off-by: WangYuli <wangyuli@uniontech.com> Signed-off-by: brightyi <brightyi@glenfly.com> Signed-off-by: WangYuli <wangyuli@uniontech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.