Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm/arise: Fix i386 config build error #390

Merged

Conversation

Avenger-285714
Copy link
Collaborator

When make i386_defconfig, here is follow error:

drivers/gpu/drm/arise/linux/os_interface.c: In function ‘gf_read64’: drivers/gpu/drm/arise/linux/os_interface.c:245:12: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
245 | return readq(addr);
| ^~~~~
| readl
cc1: all warnings being treated as errors

Link: https://gitee.com/openkylin/linux/pulls/241

When make i386_defconfig, here is follow error:

drivers/gpu/drm/arise/linux/os_interface.c: In function ‘gf_read64’:
drivers/gpu/drm/arise/linux/os_interface.c:245:12: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
  245 |     return readq(addr);
      |            ^~~~~
      |            readl
cc1: all warnings being treated as errors

Link: https://gitee.com/openkylin/linux/pulls/241
Signed-off-by: brightyi <brightyi@glenfly.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • cb_swab32函数中,移除了对cbmemsetcbmemcpy的定义,但未提供替代方案或说明移除的原因。
  • vidsch_engine_setup_e3k.c中,修改了time_interval的计算方式,使用了gf_do_div函数,但未提供该函数的实现细节,可能会影响性能。
  • vidsch_setup_e3k.c中,修改了info->value64的计算方式,使用了gf_do_div函数,但未提供该函数的实现细节,可能会影响性能。
  • krnl_task_timeout_update函数中,修改了adapter->hw_hang_fast_timeout_ns的计算方式,使用了gf_do_div函数,但未提供该函数的实现细节,可能会影响性能。
  • hwq_get_video_info函数中,修改了interval_ms的计算方式,使用了gf_do_div函数,但未提供该函数的实现细节,可能会影响性能。
  • os_interface.c中,为gf_read64函数添加了64位架构的定义,但未提供readq函数的实现细节,可能会影响跨平台兼容性。

是否建议立即修改:

  • 需要提供对cbmemsetcbmemcpy的替代实现,或者说明为什么需要移除它们。
  • 需要提供gf_do_div函数的实现细节,以确保其正确性和性能。
  • 需要检查readq函数在64位架构上的实现,以确保跨平台兼容性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714 Avenger-285714 merged commit 3dc41d9 into deepin-community:linux-6.6.y Aug 29, 2024
5 of 6 checks passed
Avenger-285714 pushed a commit to KernelSIG-cn/Linux-LTS-CN-6.6-dev that referenced this pull request Dec 29, 2024
[Glenfly]:
This version driver is the initial version for linux kernel 6.6,
and added basic arch support for amd64/arm64/loongarch64.

Test pass on deepin V23.

Version: 25.00.36.

Link: deepin-community/kernel#333
Link: https://gitee.com/openkylin/linux/pulls/241
Link: deepin-community/kernel#390
Link: deepin-community/kernel#490
Link: deepin-community/kernel#496
Link: deepin-community/kernel#509
Co-developed-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: brightyi <brightyi@glenfly.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Avenger-285714 pushed a commit to KernelSIG-cn/Linux-LTS-CN-6.6-dev that referenced this pull request Jan 4, 2025
[Glenfly]:
This version driver is the initial version for linux kernel 6.6,
and added basic arch support for amd64/arm64/loongarch64.

Test pass on deepin V23.

Version: 25.00.36.

Link: deepin-community/kernel#333
Link: https://gitee.com/openkylin/linux/pulls/241
Link: deepin-community/kernel#390
Link: deepin-community/kernel#490
Link: deepin-community/kernel#496
Link: deepin-community/kernel#509
Co-developed-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: brightyi <brightyi@glenfly.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants