Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167

Merged
merged 9 commits into from
Sep 11, 2024

Fix up chart builder to work with the latest

cb49c8b
Select commit
Loading
Failed to load commit list.
Merged

fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167

Fix up chart builder to work with the latest
cb49c8b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

46.78% (+0.02%) compared to d78ad6d

View this Pull Request on Codecov

46.78% (+0.02%) compared to d78ad6d

Details

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.78%. Comparing base (d78ad6d) to head (cb49c8b).

Files with missing lines Patch % Lines
...es/dashboard-core-plugins/src/ChartPanelPlugin.tsx 0.00% 18 Missing ⚠️
...ackages/app-utils/src/components/AppDashboards.tsx 0.00% 1 Missing ⚠️
.../dashboard-core-plugins/src/ChartBuilderPlugin.tsx 0.00% 1 Missing ⚠️
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2167      +/-   ##
==========================================
+ Coverage   46.75%   46.78%   +0.02%     
==========================================
  Files         694      694              
  Lines       38639    38627      -12     
  Branches     9785     9659     -126     
==========================================
+ Hits        18065    18070       +5     
- Misses      20521    20546      +25     
+ Partials       53       11      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.