Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167

Merged
merged 9 commits into from
Sep 11, 2024
Merged

fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167

merged 9 commits into from
Sep 11, 2024

Commits on Jul 22, 2024

  1. WIP 

    - ChartPanelPlugin just uses the panelFetch to get the underlying object
- Don't sanitize in AppDashboards - the descriptor will get sanitized in the objectFetcher itself
    @mofojed
    mofojed committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6ac3037 View commit details
    Browse the repository at this point in the history

  2. Clean up legacy plots 

    - Should be opening up correctly now...
    @mofojed
    mofojed committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    157daf3 View commit details
    Browse the repository at this point in the history

  3. Export the WidgetPanelProps as a type

    @mofojed
    mofojed committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    24a1a0f View commit details
    Browse the repository at this point in the history

  4. Use correct API when fetching a Chart object 

    - Wasn't working for charts created from Parameterized Queries
    @mofojed
    mofojed committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d15f896 View commit details
    Browse the repository at this point in the history

  5. Clean up linting errors

    @mofojed
    mofojed committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8f4736b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge remote-tracking branch 'origin/main' into fix-core-plugins-char… 

    …t-builder
    @mofojed
    mofojed committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f1d3040 View commit details
    Browse the repository at this point in the history

  2. Cleanup based on review 

    - Use useDeferredApi instead of fetching from context directly
- Allow null to be passed in for descriptor in useDeferredApi and throw an error accordingly
    @mofojed
    mofojed committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5c78f1d View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge remote-tracking branch 'origin/main' into fix-core-plugins-char… 

    …t-builder
    @mofojed
    mofojed committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    cdcec0c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix up chart builder to work with the latest 

    - Don't return an error from makeModel until the API has loaded or an error has occurred
- Allow ChartPanel to reload if makeModel has updated even if it hasn't loaded a model yet
    @mofojed
    mofojed committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cb49c8b View commit details
    Browse the repository at this point in the history