-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167
Merged
mofojed
merged 9 commits into
deephaven:main
from
mofojed:fix-core-plugins-chart-builder
Sep 11, 2024
Merged
fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise #2167
mofojed
merged 9 commits into
deephaven:main
from
mofojed:fix-core-plugins-chart-builder
Sep 11, 2024
Commits on Jul 22, 2024
-
- ChartPanelPlugin just uses the panelFetch to get the underlying object - Don't sanitize in AppDashboards - the descriptor will get sanitized in the objectFetcher itself
Configuration menu - View commit details
-
Copy full SHA for 6ac3037 - Browse repository at this point
Copy the full SHA 6ac3037View commit details -
Configuration menu - View commit details
-
Copy full SHA for 157daf3 - Browse repository at this point
Copy the full SHA 157daf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a1a0f - Browse repository at this point
Copy the full SHA 24a1a0fView commit details -
Use correct API when fetching a Chart object
- Wasn't working for charts created from Parameterized Queries
Configuration menu - View commit details
-
Copy full SHA for d15f896 - Browse repository at this point
Copy the full SHA d15f896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f4736b - Browse repository at this point
Copy the full SHA 8f4736bView commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1d3040 - Browse repository at this point
Copy the full SHA f1d3040View commit details -
- Use useDeferredApi instead of fetching from context directly - Allow null to be passed in for descriptor in useDeferredApi and throw an error accordingly
Configuration menu - View commit details
-
Copy full SHA for 5c78f1d - Browse repository at this point
Copy the full SHA 5c78f1dView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cdcec0c - Browse repository at this point
Copy the full SHA cdcec0cView commit details
Commits on Sep 10, 2024
-
Fix up chart builder to work with the latest
- Don't return an error from makeModel until the API has loaded or an error has occurred - Allow ChartPanel to reload if makeModel has updated even if it hasn't loaded a model yet
Configuration menu - View commit details
-
Copy full SHA for cb49c8b - Browse repository at this point
Copy the full SHA cb49c8bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.