Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bootstrap mixins #1692

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Dec 14, 2023

  • Fixed semantic color mappings for forms and emphasized text. Validation error labels are now red instead of white. Link sample added to the styleguide to show proper colors that were incorrectly white before
  • Added anti-aliasing to button text
  • font-weight is now bold for outlined buttons (consistent with Spectrum)

#1693

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8a74a2) 46.73% compared to head (68e5a3a) 46.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   46.73%   46.74%           
=======================================
  Files         606      606           
  Lines       36757    36762    +5     
  Branches     9227     9227           
=======================================
+ Hits        17179    17184    +5     
  Misses      19526    19526           
  Partials       52       52           
Flag Coverage Δ
unit 46.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit 3934431 into deephaven:main Dec 14, 2023
5 checks passed
@bmingles bmingles deleted the 1669-fix-bootstrap-mixins branch December 14, 2023 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap mixins
2 participants