Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap mixins #1693

Closed
bmingles opened this issue Dec 14, 2023 · 0 comments · Fixed by #1692 or deephaven/deephaven-core#4948
Closed

Bootstrap mixins #1693

bmingles opened this issue Dec 14, 2023 · 0 comments · Fixed by #1692 or deephaven/deephaven-core#4948
Assignees
@bmingles
Labels
bug Something isn't working web-client-ui

Comments

@bmingles
Copy link
Contributor

Description

There's a few issues with our custom Bootstrap mixins

  • Emphasized text does not map to our semantic colors and shows up white
  • Outline buttons don't have same font weight as filled buttons. These should match Spectrum

Versions

Web UI Version: 0.57.0
@bmingles bmingles added bug Something isn't working web-client-ui labels Dec 14, 2023
@bmingles bmingles self-assigned this Dec 14, 2023
@bmingles bmingles linked a pull request Dec 14, 2023 that will close this issue
fix: Bootstrap mixins #1692
Merged
@bmingles bmingles mentioned this issue Dec 14, 2023
Merged
bmingles added a commit that referenced this issue Dec 14, 2023
@bmingles
fix: Bootstrap mixins (#1692)
3934431 
- Fixed semantic color mappings for forms and emphasized text.
Validation error labels are now red instead of white. Link sample added
to the styleguide to show proper colors that were incorrectly white
before
- Added anti-aliasing to button text
- font-weight is now bold for outlined buttons (consistent with
Spectrum)

#1693
@mofojed mofojed mentioned this issue Dec 14, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Dec 14, 2023
@github-actions @deephaven-internal
Update web version 0.57.1 (#4948)
482cd8e 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.57.1

## [0.57.1](deephaven/web-client-ui@v0.57.0...v0.57.1) (2023-12-14)


### Bug Fixes

* Bootstrap mixins ([#1692](deephaven/web-client-ui#1692)) ([3934431](deephaven/web-client-ui@3934431)), closes [#1693](deephaven/web-client-ui#1693)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Bootstrap mixins bmingles/web-client-ui
Update web version 0.57.1 deephaven/deephaven-core
1 participant
@bmingles