-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Clean up golden-layout css #1338
Conversation
…" (deephaven#1334)" This reverts commit 2f7928a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the change to simply move it adjacent to the .js rather than in the /scss folder?
Also had to add The reference to |
// ignored because it doesn't understand the scss import in GoldenLayoutThemeExport | ||
configure: function (bundle) { | ||
bundle.on('prebundle', function () { | ||
bundle.ignore('./dist/GoldenLayoutThemeExport.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I full understand this. The ./dist/GoldenLayoutThemeExport.js
file that's outputted has a css
import, not an scss
import - so what's being ignored here specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was from the original PR, but I think it is skipping this file instead of trying to bundle it with browserify which I guess doesn't like the CSS import? Idk, but I tried removing it and the tests failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsmmcken Are all the updates screenshots correct? Looks like things shifted horizontally by a couple pixels
The screenshots should be from the original PR. I just reverted the revert commit then added the fix on top of that. |
Reverts #1334
Applies #1322 w/ a fix for enterprise builds
Still seems to need the ignore in
karma.config.cjs
though. Probably because the golden-layout package tests use old libraries