Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Freezing a tree table column crashes the panel #1192

Conversation

emilyhuxng
Copy link
Contributor

@emilyhuxng emilyhuxng commented Apr 3, 2023

Fixes #1136

Column is only freezable when the table is not a tree table.

Reset frozenColumns on rollup change.

@emilyhuxng emilyhuxng added this to the April 2023 milestone Apr 3, 2023
@emilyhuxng emilyhuxng requested a review from mofojed April 3, 2023 13:19
@emilyhuxng emilyhuxng self-assigned this Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1192 (7f0cf14) into main (dfdf356) will decrease coverage by 0.02%.
The diff coverage is 3.03%.

@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
- Coverage   44.20%   44.19%   -0.02%     
==========================================
  Files         448      448              
  Lines       33430    33440      +10     
  Branches     8401     8406       +5     
==========================================
+ Hits        14778    14779       +1     
- Misses      18602    18611       +9     
  Partials       50       50              
Flag Coverage Δ
unit 44.19% <3.03%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/dashboard-core-plugins/src/ConsolePlugin.tsx 20.83% <0.00%> (-0.09%) ⬇️
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 1.59% <0.00%> (-0.02%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 26.96% <ø> (ø)
packages/iris-grid/src/IrisGridModel.ts 31.66% <0.00%> (ø)
packages/iris-grid/src/IrisGridTreeTableModel.ts 0.00% <0.00%> (ø)
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 3.11% <0.00%> (-0.01%) ⬇️
...dashboard-core-plugins/src/events/NotebookEvent.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emilyhuxng emilyhuxng marked this pull request as ready for review April 6, 2023 15:59
@emilyhuxng emilyhuxng merged commit 5142a4d into deephaven:main Apr 6, 2023
@emilyhuxng emilyhuxng deleted the bug-1136-freezing-a-tree-table-column-crashes-the-panel branch April 6, 2023 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezing a tree table column crashes the panel
2 participants