Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freezing a tree table column crashes the panel #1136

Closed
mattrunyon opened this issue Mar 6, 2023 · 2 comments · Fixed by #1192
Closed

Freezing a tree table column crashes the panel #1136

mattrunyon opened this issue Mar 6, 2023 · 2 comments · Fixed by #1192
Assignees
@emilyhuxng
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
April 2023

Comments

@mattrunyon
Copy link
Collaborator

Description

If you have a tree/rollup table, you can right click to freeze a column and the panel will break.

Steps to reproduce

  1. Create a tree/rollup table
  2. Right click a column header that isn't in the rollup grouped columns

Expected results

  1. "Freeze column" disabled

Actual results

  1. "Freeze column" is enabled, and clicking it breaks the panel because frozen columns is not implemented for tree tables

Versions

Engine Version: 0.22.0
Web UI Version: 0.31.1
Java Version: 17.0.6
Barrage Version: 0.5.0
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Mar 6, 2023
@vbabich vbabich added this to the March 2023 milestone Mar 8, 2023
@vbabich vbabich added good first issue Good for newcomers and removed triage Issue requires triage labels Mar 8, 2023
@vbabich
Copy link
Collaborator

vbabich commented Mar 8, 2023

Double check that it also works in reverse - freeze then rollup.

@emilyhuxng
Copy link
Contributor

Double check that it also works in reverse - freeze then rollup.

Should the frozen columns remain if you reset the rollups or should they be reset? @vbabich

@emilyhuxng emilyhuxng self-assigned this Mar 29, 2023
@emilyhuxng emilyhuxng mentioned this issue Apr 3, 2023
Merged
@mofojed mofojed modified the milestones: March 2023, April 2023 Apr 3, 2023
emilyhuxng added a commit that referenced this issue Apr 6, 2023
@emilyhuxng
fix: Freezing a tree table column crashes the panel (#1192)
5142a4d 
Fixes #1136 

Column is only freezable when the table is not a tree table.

Reset `frozenColumns` on rollup change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyhuxng emilyhuxng

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

fix: Freezing a tree table column crashes the panel emilyhuxng/web-client-ui
4 participants
@vbabich @mofojed @mattrunyon @emilyhuxng