Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBox - @deephaven/components #2065

Closed
bmingles opened this issue Jun 10, 2024 · 0 comments · Fixed by #2067
Closed

ComboBox - @deephaven/components #2065

bmingles opened this issue Jun 10, 2024 · 0 comments · Fixed by #2067
Assignees
@bmingles

Comments

@bmingles
Copy link
Contributor

bmingles commented Jun 10, 2024 •
edited
Loading

@deephaven/components ComboBox component to support Deephaven UI
@bmingles bmingles self-assigned this Jun 10, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 10, 2024
@bmingles
Spectrum ComboBox (deephaven#2065)
cad1e12
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 10, 2024
@bmingles
Removed description (deephaven#2065)
c237e52
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 10, 2024
@bmingles
Updated e2e tests (deephaven#2065)
db2b47b
@bmingles bmingles mentioned this issue Jun 10, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Added getItemTextValue util (deephaven#2065)
0eb9e15
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Better textValue inference (deephaven#2065)
d90cb9b
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Fixed tests (deephaven#2065)
86f01fd
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Removed defaultItems prop (deephaven#2065)
386dd7d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
usePickerItemScale hook + tests (deephaven#2065)
0e81afc
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Comments (deephaven#2065)
033a261
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Comments (deephaven#2065)
799a628
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Comments (deephaven#2065)
7fcb1ec
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Swapped to usePickerItemScale (deephaven#2065)
d90755c
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Removed redundant sizes (deephaven#2065)
cf1f8e1
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Fixed width in styleguide (deephaven#2065)
59fdbe8
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Fixed generic types (deephaven#2065)
cfb8846
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Split out usePickerProps hook (deephaven#2065)
577735e
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Comments (deephaven#2065)
750d619
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
aria labels (deephaven#2065)
4c033e7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Unit tests (deephaven#2065)
a874cb0
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Fixed scrolling (deephaven#2065)
396f5d8
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Removed redundant prop (deephaven#2065)
4d0b951
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 11, 2024
@bmingles
Fixed topOffset and added tests (deephaven#2065)
3664f9d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Spectrum ComboBox (deephaven#2065)
04de4cf
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Removed description (deephaven#2065)
d737df9
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Updated e2e tests (deephaven#2065)
42009d4
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Added getItemTextValue util (deephaven#2065)
8c20753
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Better textValue inference (deephaven#2065)
dd669c1
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed tests (deephaven#2065)
0f363b9
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Removed defaultItems prop (deephaven#2065)
dd8213d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
usePickerItemScale hook + tests (deephaven#2065)
93584ef
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Comments (deephaven#2065)
809662a
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Comments (deephaven#2065)
18108c2
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Comments (deephaven#2065)
648b3ea
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Swapped to usePickerItemScale (deephaven#2065)
fb24369
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Removed redundant sizes (deephaven#2065)
9a51afa
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed width in styleguide (deephaven#2065)
cf6eb8d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed generic types (deephaven#2065)
82d4580
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Split out usePickerProps hook (deephaven#2065)
530a1bb
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Comments (deephaven#2065)
e93e6fc
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
aria labels (deephaven#2065)
45fbcc7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Unit tests (deephaven#2065)
a505236
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed scrolling (deephaven#2065)
65c8e07
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Removed redundant prop (deephaven#2065)
709d88b
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed topOffset and added tests (deephaven#2065)
ea02fa9
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Moved Picker props to its own module (deephaven#2065)
6d580f7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Removed confusing type (deephaven#2065)
9352d81
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Added comments (deephaven#2065)
6f86234
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Added disabledKeys and constrained to picker props type (deephaven#2065)
a9cd3b7
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
type assertions (deephaven#2065)
8c1bd97
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Simplified generics (deephaven#2065)
beda299
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2024
@bmingles
Fixed e2e test (deephaven#2065)
a19c4a7
bmingles added a commit that referenced this issue Jun 12, 2024
@bmingles
feat: ComboBox - @deephaven/components (#2067)
640e002 
* New `ComboBox` component in @deephaven/components
* Split out some shared logic from `Picker` since `ComboBox` is
basically a subclass
* Deleted old `ComboBox` component and replaced usage (condition column
+ row formatting. Also tested to make sure it still works as before)
* Updated Styleguide

resolves #2065

BREAKING CHANGE: ComboBox component has been replaced. 
To migrate to new version:
- Passing children is used instead of `options` prop to define dropdown
items. For cases where option value and display are the same, passing an
array of values as `children` will work. For cases where value and
display differ, `Item` elements must be passed as children. e.g. `<Item
key={value}>{display}</Item>`
e.g.
```typescript
// values will be used for display + value
const items = useMemo(
  () => ['Aaa', 'Bbb', 'Ccc'], 
  []
)
<ComboBox>{items}</ComboBox>
```
```typescript
<ComboBox>
  <Item key="aaa">Aaa</Item>
  <Item key="bbb">Bbb</Item>
  <Item key="ccc">Ccc</Item>
</ComboBox>
```
- The `spellcheck=false` prop is no longer supported or needed
- `searchPlaceholder` and `inputPlaceholder` props are no longer
supported and should be omitted. There is an optional `description` prop
for cases where a descriptive label is desired. There is also a `label`
prop for the primary component label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ComboBox - @deephaven/components bmingles/web-client-ui
1 participant
@bmingles