Comments (deephaven#2065)

bmingles · Jun 12, 2024 · e93e6fc · e93e6fc
1 parent 530a1bb
commit e93e6fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/components/src/spectrum/comboBox/ComboBox.tsx b/packages/components/src/spectrum/comboBox/ComboBox.tsx
@@ -23,6 +23,9 @@ export function ComboBox({
       // eslint-disable-next-line react/jsx-props-no-spreading
       {...comboBoxProps}
       UNSAFE_className={cl('dh-combobox', UNSAFE_className)}
+      // Type assertions are necessary here since Spectrum types don't account
+      // for number and boolean key values even though they are valid runtime
+      // values.
       defaultSelectedKey={
         defaultSelectedKey as SpectrumComboBoxProps<NormalizedItem>['defaultSelectedKey']
       }

diff --git a/packages/components/src/spectrum/picker/Picker.tsx b/packages/components/src/spectrum/picker/Picker.tsx
@@ -27,6 +27,9 @@ export function Picker({
       // eslint-disable-next-line react/jsx-props-no-spreading
       {...pickerProps}
       UNSAFE_className={cl('dh-picker', UNSAFE_className)}
+      // Type assertions are necessary here since Spectrum types don't account
+      // for number and boolean key values even though they are valid runtime
+      // values.
       defaultSelectedKey={
         defaultSelectedKey as NormalizedSpectrumPickerProps['defaultSelectedKey']
       }