Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-opening a closed tab panel #1785

Closed
dsmmcken opened this issue Feb 8, 2024 · 2 comments · Fixed by #1912 or deephaven/deephaven-core#5387
Closed

Allow re-opening a closed tab panel #1785

dsmmcken opened this issue Feb 8, 2024 · 2 comments · Fixed by #1912 or deephaven/deephaven-core#5387
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Feb 8, 2024

As a user, I want to be able to re-open a closed panel so that I can restore with it's state if I accidently close a tab.

Suggested changes:

  • Remember the last 15 (arbitrary number?) closed panels PER dashboard, their location and their the state when closed. This can be ephemeral between sessions, doesn't need to be persisted.
  • Add a configurable shortcut (win: alt+shift+t / mac: opt+shift+t) to re-open the closed tab
  • Add a context menu action to the panel tabs, with a right click menu option for "Re-open closed panel". It should appear in it's own group just above the close group, and display the appropriate shortcut.

Re-opening a closed tab should restore state (ie. filters, sorts, linker etc should be resorted) and pop it from the list of closed tabs. We may not be able to re-open in the same place if the stack the tab was part of is removed, so it should instead re-launch in a new position if required (but ideally opens in the same location).

@dsmmcken dsmmcken added enhancement New feature or request triage Issue requires triage labels Feb 8, 2024
@mofojed
Copy link
Member

mofojed commented Feb 8, 2024

@dsmmcken Context menu on the panel tab? Shouldn't text be "Re-open closed panel" instead? What about if you remove the last panel from the dashboard, what do you right click on then?

@dsmmcken
Copy link
Contributor Author

dsmmcken commented Feb 8, 2024

I suppose we could conditionally show a button on the "Dashboard is Empty" screen (as button centered below that text) if there's panels available to be re-opened. Does that screen exist now in DHC?

@vbabich vbabich added this to the March 2024 milestone Feb 13, 2024
@vbabich vbabich removed the triage Issue requires triage label Feb 13, 2024
@wusteven815 wusteven815 linked a pull request Apr 5, 2024 that will close this issue
wusteven815 added a commit that referenced this issue Apr 11, 2024
- Add #1785 
  - Add keyboard shortcut (Alt+Shift+A) to reopen last closed tab
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Apr 24, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.73.0

# [0.73.0](deephaven/web-client-ui@v0.72.0...v0.73.0) (2024-04-19)


### Bug Fixes

* allow plotly plots to shrink inside ui.flex/grid layouts ([#1946](deephaven/web-client-ui#1946)) ([88fbe86](deephaven/web-client-ui@88fbe86))
* Fix issues when auto-size columns/rows is false, and when row headers are not 0 ([#1927](deephaven/web-client-ui#1927)) ([01c2a06](deephaven/web-client-ui@01c2a06))


### Features

* improve table loading ([#1898](deephaven/web-client-ui#1898)) ([9b14ee0](deephaven/web-client-ui@9b14ee0)), closes [#1865](deephaven/web-client-ui#1865)
* ListView components ([#1919](deephaven/web-client-ui#1919)) ([b63ab18](deephaven/web-client-ui@b63ab18))
* log export blacklist ([#1881](deephaven/web-client-ui#1881)) ([d3fb28a](deephaven/web-client-ui@d3fb28a)), closes [#1245](deephaven/web-client-ui#1245)
* New chart error panel ([#1850](deephaven/web-client-ui#1850)) ([309ff79](deephaven/web-client-ui@309ff79)), closes [#1520](deephaven/web-client-ui#1520)
* reopen closed tabs ([#1912](deephaven/web-client-ui#1912)) ([c2e8714](deephaven/web-client-ui@c2e8714)), closes [#1785](deephaven/web-client-ui#1785)


### BREAKING CHANGES

* `LIST_VIEW_ROW_HEIGHT` number constant replaced with
dictionary `LIST_VIEW_ROW_HEIGHTS`

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants