fix: Fix issues when auto-size columns/rows is false, and when row headers are not 0 #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Apr 10, 2024
•
mofojed
commented
- Shouldn't throw in those cases, we should handle when calculatedSizes is empty
- Found when using out deephaven-doom, couldn't resize/move columns like expected
- Also tested in the styleguide - dragging columns when there were row headers visible did not work correctly
…mpty - Shouldn't throw in those cases, we should handle when calculatedSizes is empty
- It's drawing correctly, but not swapping
- Still need to get the column header to draw correctly
mofojed
changed the title
mattrunyon
requested changes
Apr 17, 2024
- Add a bit more explanation
mattrunyon
requested changes
Apr 17, 2024
mattrunyon
approved these changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.