Typing newline then space in InputEditor Component Crashes Chrome #1445
Comments
|
This appears to be a bug in Monaco itself. Upgrading to latest (0.41.0) fixes the issue. That said, there is another task that intentionally downgraded Monaco in DH, so will need to determine if upgrading introduces other problems, or if all has been resolved since the downgrade almost a year ago. I also found some older bugs in the Monaco repo that have since been closed, but they sound similar to the issue in the current version we are using (0.41.0) |
bmingles
added a commit
that referenced
this issue
Aug 16, 2023
Fixes #1445, fixes #1191 Fixing Monaco bug by upgrading to latest ^0.41.0 Supports DH-15438 BREAKING CHANGE: Monaco will need to be upgraded to ^0.41.0 in Enterprise to ensure compatibility **Tests Performed** - Console Input - `Cmd+F` does nothing - Intellisense can be closed via `Esc` - Log tab - `Esc` does not close find input - `Esc` does clear selection when focus is in the log content - Code Editor - Verified that newline with leading space no longer crashes the browser tab ``` a a ``` - Wrote some Python code. Intellisense, syntax highlighting, and general typing experience seemed as expected - Execute full code + selected code successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The component in use in the CustomColumn editor + the ACL editor crashes Chrome when typing a new line followed by typing a leading space on that line.
This was discovered in Enterprise (see DH-15438), but we suspect the fix will need to be made to Community.
Steps to reproduce
In an instance (currently in CustomColumns + Table ACL filter editro), type:
then
then
Expected results
The editor should add a leading space to the 2nd line
-->
Actual results
Chrome crashes with an "Aw Snap" message
Versions
Version 1.20230512.060beta ()
Web Client (ef239cea)
Java Eclipse Adoptium 17.0.7
The text was updated successfully, but these errors were encountered: