-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook mouse wheel and new LSP feature #1191
Comments
Yes it was triggering on signatureHelp in what you showed me on the call And on Firefox for Linux in case it is browser/OS dependent |
Reproduced on Chrome on Mac. The scrolling of the document happens when I am scrolling the popup past the top or bottom. Scrolling down when it's already at the bottom or up when it's already at the top Also applies to repl if the command is long enough to scroll |
Is this a monaco thing? |
Seems to be a bug in monaco that was fixed at some point. When I test on the latest version (0.37.0) on their playground, no issue. When I test on 0.31.1 which we use, the bug exists. The solution to this is likely just to update monaco |
Fixes #1445, fixes #1191 Fixing Monaco bug by upgrading to latest ^0.41.0 Supports DH-15438 BREAKING CHANGE: Monaco will need to be upgraded to ^0.41.0 in Enterprise to ensure compatibility **Tests Performed** - Console Input - `Cmd+F` does nothing - Intellisense can be closed via `Esc` - Log tab - `Esc` does not close find input - `Esc` does clear selection when focus is in the log content - Code Editor - Verified that newline with leading space no longer crashes the browser tab ``` a a ``` - Wrote some Python code. Intellisense, syntax highlighting, and general typing experience seemed as expected - Execute full code + selected code successfully
WRT #1178 in the context of a notebook:
When I've got a hover pop-up and I use the mouse wheel to scroll in the pop-up, everything works as expected (the mouse wheel action is confined to the limits of the pop-up).
When I'm typing and get a pop-up and I use the mouse wheel to scroll in the pop-up, the mouse wheel action effects the position of my notebook (causing the pop-up to move as well). This is not what I expect to happen. (Is this the "signatureHelp" feature?)
The text was updated successfully, but these errors were encountered: