Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook mouse wheel and new LSP feature #1191

Closed
devinrsmith opened this issue Mar 31, 2023 · 4 comments · Fixed by #1448
Closed

Notebook mouse wheel and new LSP feature #1191

devinrsmith opened this issue Mar 31, 2023 · 4 comments · Fixed by #1448
Labels
bug Something isn't working
Milestone
Backlog

Comments

@devinrsmith
Copy link
Member

WRT #1178 in the context of a notebook:

When I've got a hover pop-up and I use the mouse wheel to scroll in the pop-up, everything works as expected (the mouse wheel action is confined to the limits of the pop-up).

When I'm typing and get a pop-up and I use the mouse wheel to scroll in the pop-up, the mouse wheel action effects the position of my notebook (causing the pop-up to move as well). This is not what I expect to happen. (Is this the "signatureHelp" feature?)
@devinrsmith devinrsmith added bug Something isn't working triage Issue requires triage labels Mar 31, 2023
@devinrsmith devinrsmith mentioned this issue Mar 31, 2023
Merged
@mattrunyon
Copy link
Collaborator

Yes it was triggering on signatureHelp in what you showed me on the call

And on Firefox for Linux in case it is browser/OS dependent

@mattrunyon
Copy link
Collaborator

mattrunyon commented Mar 31, 2023 •
edited
Loading

Reproduced on Chrome on Mac. The scrolling of the document happens when I am scrolling the popup past the top or bottom. Scrolling down when it's already at the bottom or up when it's already at the top

Also applies to repl if the command is long enough to scroll

@vbabich vbabich added this to the Backlog milestone Apr 5, 2023
@vbabich vbabich removed the triage Issue requires triage label Apr 5, 2023
@dsmmcken
Copy link
Contributor

dsmmcken commented Apr 5, 2023

Is this a monaco thing?

@mattrunyon
Copy link
Collaborator

mattrunyon commented Apr 5, 2023 •
edited
Loading

Seems to be a bug in monaco that was fixed at some point. When I test on the latest version (0.37.0) on their playground, no issue. When I test on 0.31.1 which we use, the bug exists.

The solution to this is likely just to update monaco

@mattrunyon mattrunyon mentioned this issue Aug 16, 2023
Merged
bmingles added a commit that referenced this issue Aug 16, 2023
@bmingles
fix: Upgrade Monaco to ^0.41.0 (#1448)
1120c2b 
Fixes #1445, fixes #1191 Fixing Monaco bug by upgrading to latest
^0.41.0

Supports DH-15438

BREAKING CHANGE: Monaco will need to be upgraded to ^0.41.0 in
Enterprise to ensure compatibility

**Tests Performed**

- Console Input
    - `Cmd+F` does nothing
    - Intellisense can be closed via `Esc`
- Log tab
    - `Esc` does not close find input
    - `Esc` does clear selection when focus is in the log content
- Code Editor
- Verified that newline with leading space no longer crashes the browser
tab
      ```
      a
       a
      ```
- Wrote some Python code. Intellisense, syntax highlighting, and general
typing experience seemed as expected
   - Execute full code + selected code successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: Upgrade Monaco to ^0.41.0 bmingles/web-client-ui
4 participants
@dsmmcken @vbabich @devinrsmith @mattrunyon