Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add Table.diff method #5814

Merged
merged 6 commits into from
Aug 10, 2024
Merged

feat(table): add Table.diff method #5814

merged 6 commits into from
Aug 10, 2024

Commits on Aug 9, 2024

  1. Wrap TableTools.diff() as a methond on Table

    @jmao-denver
    jmao-denver committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5ba881c View commit details
    Browse the repository at this point in the history

  2. Make the Table.diff method a module func

    @jmao-denver
    jmao-denver committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d48bdbe View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
    @jmao-denver @chipkent
    jmao-denver and chipkent committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1ab10d8 View commit details
    Browse the repository at this point in the history

  4. Simplify function signature

    @jmao-denver
    jmao-denver committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5a58458 View commit details
    Browse the repository at this point in the history

  5. Fix minor format inconsistency

    @jmao-denver
    jmao-denver committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    08cda9e View commit details
    Browse the repository at this point in the history

  6. Validate floating_comparison arg value

    @jmao-denver
    jmao-denver committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3c413ce View commit details
    Browse the repository at this point in the history