Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add Table.diff method #5814

Merged
merged 6 commits into from
Aug 10, 2024
Merged

feat(table): add Table.diff method #5814

merged 6 commits into from
Aug 10, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5756

@jmao-denver jmao-denver added this to the 0.36.0 milestone Jul 19, 2024
@jmao-denver jmao-denver self-assigned this Jul 19, 2024
@jmao-denver jmao-denver changed the title feat: Wrap TableTools.diff() as a methond on Table feat(table): add Table.diff method Jul 19, 2024
chipkent
chipkent reviewed Jul 19, 2024
View reviewed changes
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Show resolved Hide resolved
py/server/tests/test_table.py Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Jul 20, 2024
View reviewed changes
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/tests/test_table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm caught up. No new comments right now.

chipkent
chipkent reviewed Jul 26, 2024
View reviewed changes
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
rcaudy
rcaudy previously approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

chipkent
chipkent reviewed Aug 7, 2024
View reviewed changes
py/server/deephaven/table.py Show resolved Hide resolved
py/server/deephaven/table.py Show resolved Hide resolved
py/server/tests/test_table.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver merged commit d26e1b2 into deephaven:main Aug 10, 2024
16 checks passed
@jmao-denver jmao-denver deleted the 5756-wrap-table-diff branch August 10, 2024 04:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#290

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@cpwright cpwright Awaiting requested review from cpwright

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
DocumentationNeeded python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

Python Wrapping for TableTools.diff
4 participants
@jmao-denver @deephaven-internal @chipkent @rcaudy