Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused gRPC method for Pandas DataFrames #3156

Merged
merged 5 commits into from
Jan 17, 2023
+2,878 −3,380
Merged

Remove unused gRPC method for Pandas DataFrames #3156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e40b55
Remove unused gRPC method for DataFrames
niloc132 Jan 13, 2023
725bd93
Remove pandas method, generate missing updateby, update license headers
niloc132 Dec 6, 2022
1f8f82e
changes
niloc132 Jan 13, 2023
b5190c2
Update authz wiring
niloc132 Jan 13, 2023
69b4444
Remove service impl
niloc132 Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion authorization/src/main/java/io/deephaven/auth/ServiceAuthWiring.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2016 - 2022 Deephaven Data Labs and Patent Pending
* Copyright (c) 2016-2022 Deephaven Data Labs and Patent Pending
*/
package io.deephaven.auth;

Expand Down
27 changes: 0 additions & 27 deletions ...zation/src/main/java/io/deephaven/auth/codegen/impl/TableServiceContextualAuthWiring.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import io.deephaven.proto.backplane.grpc.EmptyTableRequest;
import io.deephaven.proto.backplane.grpc.ExactJoinTablesRequest;
import io.deephaven.proto.backplane.grpc.ExportedTableUpdatesRequest;
import io.deephaven.proto.backplane.grpc.FetchPandasTableRequest;
import io.deephaven.proto.backplane.grpc.FetchTableRequest;
import io.deephaven.proto.backplane.grpc.FilterTableRequest;
import io.deephaven.proto.backplane.grpc.FlattenRequest;
Expand Down Expand Up @@ -70,17 +69,6 @@ void checkPermissionGetExportedTableCreationResponse(AuthContext authContext, Ti
void checkPermissionFetchTable(AuthContext authContext, FetchTableRequest request,
List<Table> sourceTables);

/**
* Authorize a request to FetchPandasTable.
*
* @param authContext the authentication context of the request
* @param request the request to authorize
* @param sourceTables the operation's source tables
* @throws io.grpc.StatusRuntimeException if the user is not authorized to invoke FetchPandasTable
*/
void checkPermissionFetchPandasTable(AuthContext authContext, FetchPandasTableRequest request,
List<Table> sourceTables);

/**
* Authorize a request to ApplyPreviewColumns.
*
Expand Down Expand Up @@ -473,9 +461,6 @@ public void checkPermissionGetExportedTableCreationResponse(AuthContext authCont
public void checkPermissionFetchTable(AuthContext authContext, FetchTableRequest request,
List<Table> sourceTables) {}

public void checkPermissionFetchPandasTable(AuthContext authContext,
FetchPandasTableRequest request, List<Table> sourceTables) {}

public void checkPermissionApplyPreviewColumns(AuthContext authContext,
ApplyPreviewColumnsRequest request, List<Table> sourceTables) {}

Expand Down Expand Up @@ -593,11 +578,6 @@ public void checkPermissionFetchTable(AuthContext authContext, FetchTableRequest
ServiceAuthWiring.operationNotAllowed();
}

public void checkPermissionFetchPandasTable(AuthContext authContext,
FetchPandasTableRequest request, List<Table> sourceTables) {
ServiceAuthWiring.operationNotAllowed();
}

public void checkPermissionApplyPreviewColumns(AuthContext authContext,
ApplyPreviewColumnsRequest request, List<Table> sourceTables) {
ServiceAuthWiring.operationNotAllowed();
Expand Down Expand Up @@ -791,13 +771,6 @@ public void checkPermissionFetchTable(AuthContext authContext, FetchTableRequest
}
}

public void checkPermissionFetchPandasTable(AuthContext authContext,
FetchPandasTableRequest request, List<Table> sourceTables) {
if (delegate != null) {
delegate.checkPermissionFetchPandasTable(authContext, request, sourceTables);
}
}

public void checkPermissionApplyPreviewColumns(AuthContext authContext,
ApplyPreviewColumnsRequest request, List<Table> sourceTables) {
if (delegate != null) {
Expand Down
Loading