Remove unused gRPC method for Pandas DataFrames #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
grpc
NoDocumentationNeeded
ReleaseNotesNeeded
|
Failing due to needing to manually run authorization regen, #3133 will automate this. |
nbauernfeind
force-pushed
the
3153-remove-unimplemented-fetch-pandas
branch
from
1bf7020 to
d38202b
Compare
nbauernfeind
previously approved these changes
Dec 8, 2022
|
Looks like there are still references to this request type in the C++ build. Should we rope in Corey or Cristian to tell us what we need to do? Or do you think these are files that would no longer be generated and just need to be deleted? (Like the FetchPandasTableRequest.java that was still in the jsapi directory.) |
nbauernfeind
previously approved these changes
Dec 8, 2022
devinrsmith
previously approved these changes
Dec 8, 2022
|
Note: |
This has been superceeded by FetchObject and a plugin for Pandas. Fixes deephaven#3153
niloc132
dismissed stale reviews from devinrsmith and nbauernfeind
via
1bf7020
niloc132
force-pushed
the
3153-remove-unimplemented-fetch-pandas
branch
from
e5d4cdf to
1bf7020
Compare
niloc132
force-pushed
the
3153-remove-unimplemented-fetch-pandas
branch
from
1bf7020 to
725bd93
Compare
devinrsmith
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was never implemented, so impact of removal should be minimal. It was superseded by FetchObject along with a plugin for Pandas, implemented in #1942.
Also updated other generated gRPC bindings that were out of date.
Fixes #3153