-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write an all-null column with a dictionary #3141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
parquet
Related to the Parquet integration
NoDocumentationNeeded
ReleaseNotesNeeded
Release notes are needed
labels
Dec 2, 2022
niloc132
force-pushed
the
3134-snappy-parquet
branch
from
December 5, 2022 22:42
ae6985c
to
3aac4be
Compare
niloc132
commented
Dec 5, 2022
niloc132
commented
Dec 5, 2022
server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
jmao-denver
previously approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
niloc132
force-pushed
the
3134-snappy-parquet
branch
from
December 6, 2022 14:39
a8f7458
to
952b82a
Compare
jmao-denver
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
NoDocumentationNeeded
parquet
Related to the Parquet integration
ReleaseNotesNeeded
Release notes are needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3134