Correct py test to include all-null col, and add null tests in java

deephaven · Dec 6, 2022 · 952b82a · 952b82a
1 parent 57d4e53
commit 952b82a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/...ons/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java b/...ons/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
@@ -77,7 +77,18 @@ private static Table getTableFlat(int size, boolean includeSerializable) {
                         "someKey = `` + (int)(i /100)",
                         "nullKey = i < -1?`123`:null",
                         "bdColumn = java.math.BigDecimal.valueOf(ii).stripTrailingZeros()",
-                        "biColumn = java.math.BigInteger.valueOf(ii)"));
+                        "biColumn = java.math.BigInteger.valueOf(ii)",
+                        "nullKey = i < -1?`123`:null",
+                        "nullIntColumn = (int)null",
+                        "nullLongColumn = (long)null",
+                        "nullDoubleColumn = (double)null",
+                        "nullFloatColumn = (float)null",
+                        "nullBoolColumn = (Boolean)null",
+                        "nullShortColumn = (short)null",
+                        "nullByteColumn = (byte)null",
+                        "nullCharColumn = (char)null",
+                        "nullTime = (DateTime)null",
+                        "nullString = (String)null"));
         if (includeSerializable) {
             columns.add("someSerializable = new SomeSillyTest(i)");
         }

diff --git a/py/server/tests/test_parquet.py b/py/server/tests/test_parquet.py
@@ -177,7 +177,7 @@ def test_round_trip_data(self):
             "nullByteColumn = (byte)null",
             "nullCharColumn = (char)null",
             "nullTime = (DateTime)null",
-            "nullKey = i == 50 ? `hi` : (String)null",
+            "nullString = (String)null",
             # TODO(deephaven-core#3151) BigInteger/BigDecimal columns don't roundtrip cleanly
             # "nullBigDecColumn = (java.math.BigDecimal)null",
             # "nullBigIntColumn = (java.math.BigInteger)null"