Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hand-wrapped the datetimeutils module, fixes #1640 #1812

Merged
merged 12 commits into from
Jan 31, 2022
Merged

hand-wrapped the datetimeutils module, fixes #1640 #1812

merged 12 commits into from
Jan 31, 2022

Commits on Jan 7, 2022

  1. hand-wrapped datetimeutils module, fixes deephaven#1640

    @jmao-denver
    jmao-denver committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    dea4523 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Addressed Devin's review comments 

    Fixed the test case problem that showed up in CI checks
    @jmao-denver
    jmao-denver committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    dd66862 View commit details
    Browse the repository at this point in the history

  2. Fixed a test case error

    @jmao-denver
    jmao-denver committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    a02b8f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Removed print() calls left in the code

    @jmao-denver
    jmao-denver committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4a1025e View commit details
    Browse the repository at this point in the history

  2. Fixed more docstring issues

    @jmao-denver
    jmao-denver committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1c2afb4 View commit details
    Browse the repository at this point in the history

  3. Corrected method types in _datetime.py 

    Also made DateTime/Period lookup-able from DType
    @jmao-denver
    jmao-denver committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f87ae31 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Added more docstrings

    @jmao-denver
    jmao-denver committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    aa74758 View commit details
    Browse the repository at this point in the history

  2. Fixed an import cycle issue

    @jmao-denver
    jmao-denver committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ce86151 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Addressed most of the concerns and suggestions 

    1. revert a lot of the changes in the PR to be consistent in using
types, based on the advice given by Ryan
2. followed the suggestions given by Chip to have a time module to be
the focal point for time related functions
3. there are still some comments that require further discussion and
clarification
    @jmao-denver
    jmao-denver committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    aa5cf6a View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Added docstring on Period string format

    @jmao-denver
    jmao-denver committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    8cf1c54 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Improved docstrings/typehints/test coverage

    @jmao-denver
    jmao-denver committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2bfbe12 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Fixed the wrong docs on to/format_nano() 

    Also added a test case to confirm the doc fix
    @jmao-denver
    jmao-denver committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    bdff19d View commit details
    Browse the repository at this point in the history