hand-wrapped the datetimeutils module, fixes #1640 #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmao-denver
commented
Jan 7, 2022
jmao-denver
commented
- refactored the dtypes module into a package
- created DateTime and Period wrapper classes under dtypes
- created datetimeutils.py
- docstrings are added in datetimeutils.py
- unit tests in test_datetimeutils.py
- minor changes here and there to tide other modules up
devinrsmith
reviewed
Jan 7, 2022
rcaudy
reviewed
Jan 8, 2022
Fixed the test case problem that showed up in CI checks
Also made DateTime/Period lookup-able from DType
chipkent
requested changes
Jan 18, 2022
devinrsmith
reviewed
Jan 18, 2022
1. revert a lot of the changes in the PR to be consistent in using types, based on the advice given by Ryan 2. followed the suggestions given by Chip to have a time module to be the focal point for time related functions 3. there are still some comments that require further discussion and clarification
chipkent
requested changes
Jan 24, 2022
chipkent
requested changes
Jan 28, 2022
Also added a test case to confirm the doc fix
chipkent
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.