Introduce AggSpec and AggregateAllByTable #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
changed the title
devinrsmith
force-pushed
the
table-api/aggregations
branch
from
cee0315 to
b6a9f51
Compare
rcaudy
reviewed
Dec 2, 2021
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationSpecAdapter.java
Outdated
Show resolved
Hide resolved
| List<Aggregation> out = new ArrayList<>(); | ||
| for (Entry<Object, List<Pair>> e : visitOrder.entrySet()) { | ||
| if (e.getKey() == COUNT_OBJ) { | ||
| for (Pair pair : e.getValue()) { |
There was a problem hiding this comment.
Suggested rename: Pair -> ColumnPair
There was a problem hiding this comment.
Going to skip for now.
table-api/src/main/java/io/deephaven/api/agg/key/KeyColumnReferences.java
Outdated
Show resolved
Hide resolved
devinrsmith
changed the title
devinrsmith
changed the title
rcaudy
reviewed
Dec 3, 2021
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Dec 3, 2021
…selectDistinct when appropriate.
rcaudy
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #1617