Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine-table aggregations need cleanup #1630

Closed
rcaudy opened this issue Dec 3, 2021 · 1 comment · Fixed by #1903
Closed

engine-table aggregations need cleanup #1630

rcaudy opened this issue Dec 3, 2021 · 1 comment · Fixed by #1903
Assignees
Labels
Milestone

Comments

@rcaudy
Copy link
Member

rcaudy commented Dec 3, 2021

As a developer, I want to be able to easily trace through the code paths for aggregations to ensure implementation correctness.
Once #1618 merges, we'll have the tools for a major cleanup pass to eliminate the last vestiges of the AggregationStateFactory objects.

In practice, we should be able to go from table-api Aggregation objects to engine-table IterativeChunkedAggregationOperator objects via a single mechanism (rather than two duplicative ones) with the business logic concentrated and easily inspected.

We should also eliminate legacy configuration objects (AggregationElement FKA ComboBy).

Lastly, we should use table-api Aggregation objects as the memoization key for aggregations.

@rcaudy rcaudy added this to the Dec 2021 milestone Dec 3, 2021
@rcaudy rcaudy self-assigned this Dec 3, 2021
@rcaudy
Copy link
Member Author

rcaudy commented Dec 3, 2021

I need to sort out format column dropping in aggBy (aggAllBy is good). Remember to annotate overloads on Table for new TableOperations, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants