Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-LTS JDK 15 as part of javadocs process #1513

Closed
devinrsmith opened this issue Nov 1, 2021 · 1 comment · Fixed by #3898
Closed

Remove non-LTS JDK 15 as part of javadocs process #1513

devinrsmith opened this issue Nov 1, 2021 · 1 comment · Fixed by #3898
Assignees
@devinrsmith
Labels
clean up
Milestone
Jun 2022

Comments

@devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the Nov 2021 milestone Nov 1, 2021
@devinrsmith devinrsmith self-assigned this Nov 1, 2021
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 1, 2021
@devinrsmith
Choose generic versions for Java version in CI
e0d614f 
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java.

In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that.

JDK 17 should be pre-installed as part of actions/runner-images#4085

See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

Follow up, deephaven#1513
@devinrsmith devinrsmith mentioned this issue Nov 1, 2021
Merged
devinrsmith added a commit that referenced this issue Nov 1, 2021
@devinrsmith
Choose generic versions for Java version in CI (#1514)
2f13538 
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java.

In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that.

JDK 17 should be pre-installed as part of actions/runner-images#4085

See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

Follow up, #1513
@pete-petey pete-petey modified the milestones: Nov 2021, Jan 2022 Dec 29, 2021
@pete-petey
Copy link
Member

Pending #1529

@pete-petey pete-petey modified the milestones: Jan 2022, Jun 2022 Apr 16, 2022
niloc132 added a commit to niloc132/deephaven-core that referenced this issue May 31, 2023
@niloc132
Refactor javadoc build to be more reusable
8f0a72e 
Fixes deephaven#1513
@niloc132 niloc132 mentioned this issue May 31, 2023
Merged
niloc132 added a commit that referenced this issue Jun 2, 2023
@niloc132
Correct Javadoc warnings, prevent future ones (#3898)
4c5fc89 
Addresses several classes of issues, some in more than one way:
* Ensure all javadoc runs use UTF-8 encoding, and remove non-ASCII chars which are intended to be interpreted as code
* HTML-encode characters that must be encoded in javadoc, and correct wrongly-encoded chars.
* Don't reference JVM internals that can't be linked, instead refer to them as @code.
* Fixed mismatched html tags, broken attrs.
* Corrected/removed classes/members that don't exist or can't be referenced in that way.

Fixes #1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
clean up
Projects
None yet
Milestone
Jun 2022
Development

Successfully merging a pull request may close this issue.

Correct Javadoc warnings, prevent future ones niloc132/deephaven-core
2 participants
@devinrsmith @pete-petey